From d8e916dbe6a51276a4b56315596b7f91ca46e6be Mon Sep 17 00:00:00 2001 From: Richie Cahill Date: Sun, 14 Jun 2026 13:38:14 -0400 Subject: [PATCH] fixed type bug in get_snapshots --- python/zfs/dataset.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/python/zfs/dataset.py b/python/zfs/dataset.py index 35f5689..a184c78 100644 --- a/python/zfs/dataset.py +++ b/python/zfs/dataset.py @@ -108,7 +108,7 @@ class Dataset: self.written = int(properties["written"]["value"]) self.xattr = properties["xattr"]["value"] - def get_snapshots(self) -> list[Snapshot] | None: + def get_snapshots(self) -> list[Snapshot]: """Get all snapshots from zfs and process then is test dicts of sets.""" snapshots_data = _zfs_list(f"zfs list -t snapshot -pHj {self.name} -o all") @@ -125,10 +125,10 @@ class Dataset: if return_code == 0: return "snapshot created" - if snapshots := self.get_snapshots(): - snapshot_names = {snapshot.name for snapshot in snapshots} - if snapshot_name in snapshot_names: - return f"Snapshot {snapshot_name} already exists for {self.name}" + snapshots = self.get_snapshots() + snapshot_names = {snapshot.name for snapshot in snapshots} + if snapshot_name in snapshot_names: + return f"Snapshot {snapshot_name} already exists for {self.name}" return f"Failed to create snapshot {snapshot_name} for {self.name}"