Refactor logging statements to use f-strings for improved readability and consistency across the codebase. This change enhances the clarity of log messages by directly embedding variable values, making it easier to trace and debug application behavior.

python/ebook_search/ingest.py

@@ -94,13 +94,13 @@ async def ingest_configured_paths(session: AsyncSession, config: EbookSearchConf
     count = 0
     for library_path in config.library_paths:
         path, epub_paths = await asyncio.to_thread(find_library_epubs, library_path)
-        logger.info("ebook_ingest_path_start path=%s", path)
+        logger.info(f"ebook_ingest_path_start {path=}")
         if epub_paths is None:
-            logger.warning("ebook_ingest_path_missing path=%s", path)
+            logger.warning(f"ebook_ingest_path_missing {path=}")
             continue
         for epub_path in epub_paths:
             count += int(await ingest_file(session, epub_path, config))
-    logger.info("ebook_ingest_paths_complete changed_files=%s configured_paths=%s", count, len(config.library_paths))
+    logger.info(f"ebook_ingest_paths_complete {count=} configured_paths={len(config.library_paths)}")
     return count
 
 
@@ -113,7 +113,7 @@ async def ingest_file(session: AsyncSession, path: Path, config: EbookSearchConf
     """Ingest one EPUB file. Return True when the database changed."""
     try:
         resolved_path = await asyncio.to_thread(resolve_ingest_path, path)
-        logger.info("ebook_ingest_file_start path=%s", resolved_path)
+        logger.info(f"ebook_ingest_file_start {resolved_path=}")
         file_hash = await asyncio.to_thread(sha256_file, resolved_path)
         existing = await find_existing_source(session, resolved_path, file_hash)
         if existing is not None and existing.file_sha256 == file_hash:
@@ -122,10 +122,10 @@ async def ingest_file(session: AsyncSession, path: Path, config: EbookSearchConf
             existing.file_mtime = datetime.fromtimestamp(stat.st_mtime, tz=UTC)
             existing.file_size = stat.st_size
             await session.flush()
-            logger.info("ebook_ingest_file_unchanged source_id=%s path=%s", existing.id, resolved_path)
+            logger.info(f"ebook_ingest_file_unchanged {existing.id=} {resolved_path=}")
             return False
         if existing is not None:
-            logger.info("ebook_ingest_file_replacing source_id=%s path=%s", existing.id, resolved_path)
+            logger.info(f"ebook_ingest_file_replacing {existing.id=} {resolved_path=}")
             await session.delete(existing)
             await session.flush()
 
@@ -160,15 +160,11 @@ async def ingest_file(session: AsyncSession, path: Path, config: EbookSearchConf
         await session.commit()
         mention_count = await index_chunk_phrase_mentions_for_book(session, source.id, config)
         logger.info(
-            "ebook_ingest_file_complete source_id=%s path=%s chapters=%s chunks=%s phrase_mentions=%s",
-            source.id,
-            resolved_path,
-            len(parsed.chapters),
-            chunk_index,
-            mention_count,
+            f"ebook_ingest_file_complete {source.id=} {resolved_path=} chapters={len(parsed.chapters)} {chunk_index=} "
+            f"{mention_count=}"
         )
     except Exception:
-        logger.exception(f"ebook_ingest_file_error path={path}")
+        logger.exception(f"ebook_ingest_file_error {path=}")
         return False
     else:
         return True