Richie/dotfiles
1
0
Fork 0
mirror of https://github.com/RichieCahill/dotfiles.git synced 2026-04-17 04:58:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix code rabbit warnings

Browse Source
This commit is contained in:
Richie Cahill
2026-02-18 16:47:46 -05:00
parent f038f248a1
commit 70d20e55d2
1 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
python/eval_warnings/main.py
View File

@@ -98,12 +98,11 @@ def parse_warnings(logs: dict[str, str]) -> set[EvalWarning]:
for name, content in sorted(logs.items()): for name, content in sorted(logs.items()):
system = name.split("/")[0].removeprefix("build-") system = name.split("/")[0].removeprefix("build-")
for line in content.splitlines(): for line in content.splitlines():
if line.startswith("warning: ignoring untrusted flake configuration setting"):
logger.info("Ignoring untrusted flake configuration setting warning.")
continue
if warning_pattern.search(line): if warning_pattern.search(line):
logger.debug(f"Found warning: {line}")
message = timestamp_prefix.sub("", line).strip() message = timestamp_prefix.sub("", line).strip()
if message.startswith("warning: ignoring untrusted flake configuration setting"):
continue
logger.debug(f"Found warning: {line}")
warnings.add(EvalWarning(system=system, message=message)) warnings.add(EvalWarning(system=system, message=message))
logger.info("Found %d unique warnings", len(warnings)) logger.info("Found %d unique warnings", len(warnings))
@@ -260,7 +259,7 @@ say so in REASONING and do not suggest changes"""
def parse_changes(response: str) -> list[FileChange]: def parse_changes(response: str) -> list[FileChange]:
"""Parse file changes from the LLM response. """Parse file changes from the **CHANGES** section of the LLM response.
Expects blocks in the format: Expects blocks in the format:
FILE: path/to/file.nix FILE: path/to/file.nix
@@ -276,13 +275,19 @@ def parse_changes(response: str) -> list[FileChange]:
Returns: Returns:
List of parsed file changes. List of parsed file changes.
""" """
if "**CHANGES**" not in response:
logger.warning("LLM response missing **CHANGES** section")
return []
changes_section = response.split("**CHANGES**", 1)[1]
changes: list[FileChange] = [] changes: list[FileChange] = []
current_file = "" current_file = ""
section: str | None = None section: str | None = None
original_lines: list[str] = [] original_lines: list[str] = []
fixed_lines: list[str] = [] fixed_lines: list[str] = []
for line in response.splitlines(): for line in changes_section.splitlines():
stripped = line.strip() stripped = line.strip()
if stripped.startswith("FILE:"): if stripped.startswith("FILE:"):
current_file = stripped.removeprefix("FILE:").strip() current_file = stripped.removeprefix("FILE:").strip()
@@ -315,8 +320,12 @@ def apply_changes(changes: list[FileChange]) -> int:
Number of changes successfully applied. Number of changes successfully applied.
""" """
applied = 0 applied = 0
cwd = Path.cwd().resolve()
for change in changes: for change in changes:
path = Path(change.file_path) path = Path(change.file_path).resolve()
if not path.is_relative_to(cwd):
logger.warning("Path traversal blocked: %s", change.file_path)
continue
if not path.is_file(): if not path.is_file():
logger.warning("File not found: %s", change.file_path) logger.warning("File not found: %s", change.file_path)
continue continue