fix(ebook-search): skip comment lines in gold query loader and realign tests
treefmt / nix fmt (pull_request) Successful in 10s
pytest / pytest (pull_request) Successful in 31s
build_systems / build-brain (pull_request) Successful in 52s
build_systems / build-bob (pull_request) Successful in 52s
build_systems / build-jeeves (pull_request) Successful in 2m43s
build_systems / build-leviathan (pull_request) Successful in 59s
build_systems / build-rhapsody-in-green (pull_request) Successful in 1m5s
treefmt / nix fmt (pull_request) Successful in 10s
pytest / pytest (pull_request) Successful in 31s
build_systems / build-brain (pull_request) Successful in 52s
build_systems / build-bob (pull_request) Successful in 52s
build_systems / build-jeeves (pull_request) Successful in 2m43s
build_systems / build-leviathan (pull_request) Successful in 59s
build_systems / build-rhapsody-in-green (pull_request) Successful in 1m5s
load_gold_queries now skips blank and `//` comment lines so the committed
section separator in queries.jsonl no longer breaks dataset/load-test loading.
Update tests left stale by the search refactor (6bc3011):
- pass the now-required rank_constant to reciprocal_rank_fusion
- expect bm25_candidates to receive the full query and drop the removed
"BM25 query preparation" timing step
- assert reranking is enabled by default
This commit is contained in:
@@ -33,7 +33,7 @@ def rerank_response(payload: dict[str, object] | None = None, *, content: bytes
|
||||
)
|
||||
|
||||
|
||||
def test_config_defaults_keep_reranking_optional(mocker: MockerFixture) -> None:
|
||||
def test_config_defaults_enable_reranking(mocker: MockerFixture) -> None:
|
||||
mocker.patch.dict(environ, {}, clear=False)
|
||||
environ.pop("EBOOK_SEARCH_RERANK_ENABLED", None)
|
||||
environ.pop("EBOOK_SEARCH_RERANK_BASE_URL", None)
|
||||
@@ -43,7 +43,7 @@ def test_config_defaults_keep_reranking_optional(mocker: MockerFixture) -> None:
|
||||
|
||||
config = load_rerank_config()
|
||||
|
||||
assert config.enabled is False
|
||||
assert config.enabled is True
|
||||
assert config.base_url == "http://192.168.90.25:8001"
|
||||
assert config.model == "qwen3-reranker-06b"
|
||||
assert config.candidates == 24
|
||||
|
||||
Reference in New Issue
Block a user